Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contracts: added test for EIP-155 compatibility #293

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

contracts: added test for EIP-155 compatibility #293

wants to merge 1 commit into from

Conversation

CedarMist
Copy link
Member

@CedarMist CedarMist commented Mar 26, 2024 •
edited by matevz
Loading

Tests that Multicall can be deployed: https://github.com/mds1/multicall

This test will intentionally fail until Sapphire can accept an EIP-155 transaction with no Chain ID (currently it's rejected).

Currently the error is:

  • client: transaction check failed: runtime error: module: core code: 1 message: malformed transaction: chain ID None, expected Some(23293)"

@CedarMist CedarMist added p:2 Priority: nice to have contracts Pull requests that update sapphire-contracts labels Mar 26, 2024
@CedarMist CedarMist self-assigned this Mar 26, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 26, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.

Name Link
🔨 Latest commit 24c9c55
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/6602f3a2d1b9cf0008ad8384

@matevz matevz changed the title contracts: added test for EIP-1559 compatibility contracts: added test for EIP-155 compatibility Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CedarMist CedarMist

Labels
contracts Pull requests that update sapphire-contracts p:2 Priority: nice to have
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CedarMist